WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel][PATCH]fix vti inital broken after merge

To: "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
Subject: RE: [Xen-ia64-devel][PATCH]fix vti inital broken after merge
From: "Zhang, Xing Z" <xing.z.zhang@xxxxxxxxx>
Date: Tue, 5 Dec 2006 10:24:36 +0800
Cc: xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 04 Dec 2006 18:28:36 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccXSvsVl8k/qL7cRnaqA3ojoHngQQAw6VGg
Thread-topic: [Xen-ia64-devel][PATCH]fix vti inital broken after merge
Hi Yamahata:
        Thanks for your mention. 
        With your patch, seems we can pass pfn to xc_map_foreign_range(). As 
you said, change in populate_physmap() seems unnecessary. But I noticed IA32 
still have this logic. So I think xc_domain_memory_populate_physmap() also need 
auto-translate mechanism. we should pass pfn to xc_map_foreign_range() solely 
but not use gpfn array which pass to xc_domain_memory_populate_physmap(). IA32 
do like this. 
        Meanwhile, I found it seems your patch has not checked in, so if I 
don't do these changes, vti will go on block. If my patch checked in xen-devel, 
I'm afraid you may need modify setup_guest() in xc_linux_build.c. I'm sorry for 
the inconvenience.  


Good good study,day day up ! ^_^
-Wing(zhang xin)
 
OTC,Intel Corporation

>-----Original Message-----
>From: Isaku Yamahata [mailto:yamahata@xxxxxxxxxxxxx]
>Sent: 2006年12月4日 10:22
>To: Zhang, Xing Z
>Cc: Alex Williamson; xen-ia64-devel
>Subject: Re: [Xen-ia64-devel][PATCH]fix vti inital broken after merge
>
>On Fri, Dec 01, 2006 at 10:43:47AM -0700, Alex Williamson wrote:
>
>> > diff -r edaf70bb5bcc xen/common/memory.c
>> > --- a/xen/common/memory.c       Thu Nov 30 02:58:43 2006 +0800
>> > +++ b/xen/common/memory.c       Fri Dec 01 02:30:19 2006 +0800
>> > @@ -137,6 +137,10 @@ static void populate_physmap(struct memo
>> >          {
>> >              for ( j = 0; j < (1 << a->extent_order); j++ )
>> >                  guest_physmap_add_page(d, gpfn + j, mfn + j);
>> > +
>> > +            /* Inform the domain of the new page's machine address.
>> > */
>> > +            if ( unlikely(__copy_to_guest_offset(a->extent_list, i,
>> > &mfn, 1)) )
>> > +                goto out;
>> >          }
>> >          else
>> >          {
>>
>>    This chunk will need to be submitted to xen-devel.  Thanks,
>
>The foreign domain page mapping semantic of auto translated mode domain
>was changed on x86.
>The above patch of
>http://lists.xensource.com/archives/html/xen-ia64-devel/2006-11/msg00360.ht
>ml
>catches it up on IA64.
>This chunk will be unnecessary with it
>
>--
>yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel