WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-devel] Re: [Xen-changelog] [xen-unstable] [IA64] fix xencomm_handle

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [Xen-changelog] [xen-unstable] [IA64] fix xencomm_handle_is_null().
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Thu, 16 Nov 2006 09:55:42 -0600
Cc: xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 16 Nov 2006 07:56:03 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E1Gk8pJ-0007ef-Tr@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <E1Gk8pJ-0007ef-Tr@xxxxxxxxxxxxxxxxxxxxx>
Reply-to: Hollis Blanchard <hollisb@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2006-11-15 at 00:40 +0000, Xen patchbot-unstable wrote:
> # HG changeset patch
> # User awilliam@xxxxxxxxxxx
> # Node ID 3713ea43e6364bf2989a1cf0dc252a6a1393ce02
> # Parent  8533c59c5b40df0f6e6d03cbc8a74057dcbed5db
> [IA64] fix xencomm_handle_is_null().
> 
> It checks only desc->address[0]. However xencomm_add_offset() may
> sets XENCOMM_INVALID while there left consumable bytes.
> In such a case xencomm_handle_is_null() returns true wrongly.
> 
> Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
> ---
>  xen/arch/ia64/xen/xencomm.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff -r 8533c59c5b40 -r 3713ea43e636 xen/arch/ia64/xen/xencomm.c
> --- a/xen/arch/ia64/xen/xencomm.c     Fri Nov 10 11:14:36 2006 -0700
> +++ b/xen/arch/ia64/xen/xencomm.c     Fri Nov 10 11:14:42 2006 -0700
> @@ -382,6 +382,6 @@ xencomm_handle_is_null(
>              return 1;
> 
>          desc = (struct xencomm_desc *)desc_addr;
> -        return (desc->address[0] == XENCOMM_INVALID);
> -    }
> -}
> +        return (desc->nr_addrs == 0);
> +    }
> +}

I think I'm missing something. Why did IA64 fork xencomm?

I distinctly remember having conversations about sharing the code, which
is obviously the right thing to do.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>