WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-devel] [PATCH 2/3] blktap: mb fixes

On Tue, Nov 07, 2006 at 11:16:13AM +0000, Keir Fraser wrote:
> Applied, except for one chunk which added a barrier before update of
> req_cons. This was not mentioned in the changeset comment and I do not
> believe there is any race that needs fixing (certainly not between memcpy of
> request data and read of req_cons in make_response()). I applied the rest of
> the patch as-is.

Thanks you for applying.
Hmm.. since you don't believe any race, then please revert
this mb patch except NULL check chunk.
I certainly observed that tapdisk failed to get new request on IA64.
If it is really caused by the race, I will sent a patch again.
(or I'll sent another patch which fixes another issues)

BTW,
why is wmb() in write_rsp_to_ring() of tools/blktap/drivers/tapdisk.c
necessary?
RING_PUSH_RESPONSES() of kick_responses() issues wmb() so that
wmb() in write_rsp_to_ring() isn't needed, I think.

thanks.
-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>