Re: [Xen-ia64-devel] [PATCH 1/12]MCA handler support for Xen/ia64 TAKE 2

[Alex Williamson <alex.williamson@xxxxxx>]

On Thu, 2006-09-28 at 16:10 +0900, SUZUKI Kazuhiro wrote:
> > 
> >       * It looks like we're not returning a value for several functions
> >         that specify a return type.  Please make sure the code compiles
> >         cleanly.
> 
>   I'm sorry but I cannot find such functions. Please teach me which
> functions correspond.
> It is confirmed that no warnings are found when compiling.

Hi Kaz,

   My mistake, I didn't check back that irqreturn_t is typedef'd to a
void on Xen.  However, I don't see anybody actually using IRQ_HANDLED.
Perhaps we could #define IRQ_HANDLED (to nothing) to avoid all the

#ifndef XEN
        return IRQ_HANDLED;
#else
        return;
#endf

Also, I think you can skip the /* XEN */ on every #else/#endif.  As long
as the #if/#else/#endif are all pretty close together (within an 80x24
screen) and not interspersed with other #ifdefs.
> 
> >       * #define'ing mod_timer to set_timer may help remove #ifdef XEN in
> >         a few places.
> 
>   I defined `mod_timer' macro and removed several #ifdef XEN.

   Thanks, I think the same should be done with setup_irq/setup_vector.

> +             e = xmalloc(sal_queue_entry_t);
> +             e->cpuid = smp_processor_id();
> +             e->sal_info_type = sal_info_type;
> +             e->vector = IA64_CMC_VECTOR;
> +             e->virq = virq;
> +             e->length = total_len;

   Shouldn't we check that the xmalloc didn't return NULL?  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel