Re: [Xen-ia64-devel] [PATCH 1/12]MCA handler support for Xen/ia64 TAKE 2

[Jes Sorensen <jes@xxxxxxx>]

>>>>> "Kazuhiro" == SUZUKI Kazuhiro <kaz@xxxxxxxxxxxxxx> writes:

> +#ifndef      XEN 
>  static struct timer_list cpe_poll_timer;
>  static struct timer_list cmc_poll_timer;
> +#else /* XEN */
> +static struct timer cpe_poll_timer;
> +static struct timer cmc_poll_timer;
> +#endif

Hi Kazuhiro,

Any chance we could start using sane names in Xen that match the Linux
names so we don't have to end up with a ton of #ifdef XEN changes like
that? It makes it really difficult to read and maintain the code long
term.

Cheers,
Jes

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel