WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel][PATCH]Complete fpswa handler retry mechanism

To: "Xu, Anthony" <anthony.xu@xxxxxxxxx>
Subject: Re: [Xen-ia64-devel][PATCH]Complete fpswa handler retry mechanism
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Sun, 24 Sep 2006 15:28:36 -0600
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 24 Sep 2006 14:29:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <01913ADC4FF97E40AE0E2B001574AEE163C0EA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <01913ADC4FF97E40AE0E2B001574AEE163C0EA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2006-09-22 at 16:27 +0800, Xu, Anthony wrote:
> When handling fpswa fault, Xen needs to fetch opcode, it may fail.
> This patch finishes retry mechanism.
...
--- a/xen/include/asm-ia64/ia64_int.h   Fri Sep 22 14:27:04 2006 +0800
+++ b/xen/include/asm-ia64/ia64_int.h   Fri Sep 22 15:02:28 2006 +0800
@@ -36,7 +36,7 @@
 #define        IA64_NO_FAULT           0x0000
 #define IA64_FAULT                     0x0001
 #define        IA64_RFI_IN_PROGRESS    0x0002
-#define IA64_RETRY              0x0003
+#define IA64_RETRY              (-0xf)
 #define IA64_FORCED_IFA         0x0004
 #define IA64_USE_TLB           0x0005
 #define        IA64_ILLOP_FAULT        (IA64_GENEX_VECTOR | 0x00)

Hi Anthony,

   Why change IA64_RETRY to such an obscure value?  If it's necessary,
please add a comment.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>