Re: [Xen-ia64-devel][PATCH] Fix a bug related to vcpu migration

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Thu, Sep 21, 2006 at 11:22:27AM +0800, Xu, Anthony wrote:

> >domain_flush_tlb_vhpt() called by arch_domain_destroy()
> >addresses this scneario.
> >I don't think the patch resolves the domain crash issue because it
> >flushes TLB before region ID range is reused.
> Yes, you are right, domain_flush_tlb_vhpt() can addresses this scenario.
> One comment about flush_tlb_vhpt_all,
> 
> static void flush_tlb_vhpt_all (struct domain *d)
> {
>       /* First VHPT.  */
> >>>> if d is not VMX domain
>       vhpt_flush ();
> 
>       /* Then mTLB.  */
>       local_flush_tlb_all ();
> }

Now I see your point.
Then arch_domain_destroy() or domain_flush_tlb_vhpt() should be fixed.
make it be aware of domVTI.

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel