Re: [Xen-devel] PATCH: makes acm_setup arch independant

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Wed, 2006-09-06 at 15:49 -0400, Stefan Berger wrote:
> 
> A minor issue is whether as much as possible of the ACM-specific code
> should be kept inside the acm directory and we use #ifdefs like
> 
> #if defined(__i386__)
> 
> #if defined(__x86_64__)
> 
> to compile architecture-specific functions there, or whether functions like
> the extract_acm_policy below should be surrounded by #ifdef ACM_SECURITY
> and they can stay inside the architecture-specific code. The assumption
> would be that no one boots with an ACM policy if the compile time option
> ACM_SECURITY was not set. Thoughts?

I think I'd prefer adding this to xen/acm/Makefile:
        obj-$(CONFIG_POWERPC) += acm_powerpc.o
        obj-$(CONFIG_IA64) += acm_ia64.o

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel