WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel][PATCH] Enable SMP on VTI domain.

To: "Xu, Anthony" <anthony.xu@xxxxxxxxx>
Subject: Re: [Xen-ia64-devel][PATCH] Enable SMP on VTI domain.
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Wed, 21 Jun 2006 18:25:13 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 21 Jun 2006 02:26:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <2BF508F394C196468CCBEC031320DCDF0116FE92@pdsmsx405>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <2BF508F394C196468CCBEC031320DCDF0116FE92@pdsmsx405>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Thu, Jun 01, 2006 at 12:55:08PM +0800, Xu, Anthony wrote:

> >> Or you mean the protection of global purge.
> >> When a vcpu get IPI to purge TLB,
> >> What it does is to invalid the TLB entry in VHPT,
> >> but not remove the TLB entry.
> >> There is no race condition.
> >
> >Is there any gurantee that the vcpu which recives IPI isn't touching VHPT?
> 
> The vcpu which receives IPI can touch VHPT in the same time.
> Because purge operation only sets the TLB entry invalid, like entry->ti=1.
> That has the same philosophy with Tristan's direct purge

Could you review the two attached patches?
Purge function traverses the collision chain when IPI is sent.
But there is a window when the assumption of the collision chain
is broken.
vmx_hpw_miss() has a race. ia64_do_page_fault() had a similar race before.

-- 
yamahata

Attachment: 10474:c5c599141647_local_irq_save_local_irq_restore.patch
Description: Text document

Attachment: 10475:c7cd1af74a38_vtlb_vhpt_collision_chain_may_have_invalid_entry.patch
Description: Text document

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel