WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

PATCH: was Re: [Xen-ia64-devel] Re: PATCH: cleanup

To: Alex Williamson <alex.williamson@xxxxxx>
Subject: PATCH: was Re: [Xen-ia64-devel] Re: PATCH: cleanup
From: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Date: Fri, 16 Jun 2006 10:09:43 +0200
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 16 Jun 2006 01:05:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1150385368.5523.16.camel@lappy>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200606151336.41167.Tristan.Gingold@xxxxxxxx> <1150385368.5523.16.camel@lappy>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.5
Le Jeudi 15 Juin 2006 17:29, Alex Williamson a écrit :
> Hi Tristan,
>
>    The CONFIG_PRIVIFY setting is kind of strange to me.  I think I'd
> prefer a #ifdef here:
>
> On Thu, 2006-06-15 at 13:36 +0200, Tristan Gingold wrote:
> > +#if CONFIG_PRIVIFY
> > +               /* Some privified operations are coded using reg+64
>
> Then this:
> >  /* Set to 1 to handle privified instructions from the privify tool.
> > */
> > -static const int privify_en = 0;
> > +#ifndef CONFIG_PRIVIFY
> > +#define CONFIG_PRIVIFY 0
> > +#endif
> > +static const int privify_en = CONFIG_PRIVIFY;
>
> could be
>
> #ifndef CONFIG_PRIVIFY
> static const int privify_en = 0;
> #else
> static const int privify_en = 1;
> #endif
>
> I don't like overloading CONFIG_* with #ifdef and #ifs.  Thanks,
Here is the updated patch (and somewhat completed).

tested by booting dom0.

Tristan.

Attachment: xen-cleanup5.diffs
Description: Text Data

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel