WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] [PATCH] sparse tree cleanups

To: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [PATCH] sparse tree cleanups
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Wed, 07 Jun 2006 08:04:17 -0600
Cc: xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 07 Jun 2006 07:04:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <19C689F8D0A5A3takebe_akio@xxxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <1149625245.5877.57.camel@lappy> <19C689F8D0A5A3takebe_akio@xxxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2006-06-07 at 15:08 +0900, Akio Takebe wrote:
> Hi, Alex
> 
> I agree your suggestion.
> But your patch use ifdef CONFIG_XEN.
> You say we use "simple is_running_on_xen() checks", aren't you?
> Is this mistake? or do I mis-understand?
> 
> I want to clean up mm/memory.c.
> (This work is for cleanup fedora-xen's warning.)
> I should use is_running_on_xen() in mm/memory.c, shouldn't I?

Hi Akio,

   Without seeing the changes, it's hard to say.  What I mean by simple
checks are that it cannot call functions or declare variables that are
only defined in CONFIG_XEN code.  It's minor cleanup that you may not be
able to use.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>