WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

RE: [Xen-ia64-devel][PATCH] fixed a bug which causes Oops

To: "Alex Williamson" <alex.williamson@xxxxxx>
Subject: RE: [Xen-ia64-devel][PATCH] fixed a bug which causes Oops
From: "Xu, Anthony" <anthony.xu@xxxxxxxxx>
Date: Fri, 2 Jun 2006 16:10:13 +0800
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 02 Jun 2006 01:10:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcaEzQlKRUxF07q5QXiYz06n0hvqNQBTrlMg
Thread-topic: [Xen-ia64-devel][PATCH] fixed a bug which causes Oops
Resend

Thanks,
-Anthony 

>-----Original Message-----
>From: Alex Williamson [mailto:alex.williamson@xxxxxx]
>Sent: 2006?6?1? 0:10
>To: Xu, Anthony
>Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>Subject: Re: [Xen-ia64-devel][PATCH] fixed a bug which causes Oops
>
>On Wed, 2006-05-31 at 12:13 +0800, Xu, Anthony wrote:
>> @@ -171,8 +174,11 @@ void vtm_set_itm(VCPU *vcpu, uint64_t va
>>      clear_bit(ITV_VECTOR(vitv), &VCPU(vcpu, irr[0]));
>>      VCPU(vcpu,itm)=val;
>>      cur_itc =now_itc(vtm);
>> +    diff_itc = val-cur_itc;
>> +    if(diff_itc < 0)
>> +        diff_itc = 0;
>>      if(val >  vtm->last_itc){
>> -        expires = NOW() + cycle_to_ns(val-cur_itc) + TIMER_SLOP;
>> +        expires = NOW() + cycle_to_ns(diff_itc) + TIMER_SLOP;
>
>Hi Anthony,
>
>  I think this should probably use time_after(), something like:
>
>    if (time_after(val, cur_itc))
>        val = cur_itc;
>
>Thanks,
>
>       Alex
>
>--
>Alex Williamson                             HP Open Source & Linux Org.

Attachment: new_vti_oops_fix.patch
Description: new_vti_oops_fix.patch

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
<Prev in Thread] Current Thread [Next in Thread>
  • RE: [Xen-ia64-devel][PATCH] fixed a bug which causes Oops, Xu, Anthony <=