xen-ia64-devel

[Top] [All Lists]

Re: [Xen-ia64-devel] [RFC] cleanup warning (redefine MMIO_SIZE)

from [Alex Williamson]

[Permanent Link][Original]

To:	Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Subject:	Re: [Xen-ia64-devel] [RFC] cleanup warning (redefine MMIO_SIZE)
From:	Alex Williamson <alex.williamson@xxxxxx>
Date:	Thu, 01 Jun 2006 08:43:36 -0600
Cc:	fedora-xen@xxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Thu, 01 Jun 2006 07:43:57 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<200606011347.19199.Tristan.Gingold@xxxxxxxx>
List-help:	<mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id:	Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post:	<mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	OSLO R&D
References:	<45C6856E923A0Ctakebe_akio@xxxxxxxxxxxxxx> <200606011347.19199.Tristan.Gingold@xxxxxxxx>
Sender:	xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Thu, 2006-06-01 at 13:47 +0200, Tristan Gingold wrote:
> Le Jeudi 01 Juin 2006 13:28, Akio Takebe a écrit :
> > Hi, all
> >
> > This issue is only for fedora-xen-ia64.
> > fedora-xen-ia64 turn on CONFIG_FB_NEOMAGIC in .config.
> > (xen-ia64-unstable is default turn off it)
> > In the case of CONFIG_FB_NEOMAGIC=y, MMIO_SIZE is redefine.
> > I think MMIO_SIZE in arch-ia64.h is only used
> > in arch-ia64.h and xen/arch/ia64/vmx/vmx_init.c.
> > Am I right?
> >
> > We should move some defines(e.g. MMIO_xxx) from public header
> > to not public header because they are used only
> > in vmx_init.c, shouldn't we?
> Yes.  In my opinion, arch-ia64.h must be as small as possible and identifiers 
> should be in the 'xen' name space.  We are very far from the last point!

   I agree as well.  However, I also think the fedora-xen-ia64 tree
should turn off CONFIG_FB_NEOMAGIC.  AFAIK, there's absolutely no way
that you'd ever need to use the NeoMagic frame buffer driver on an ia64
system.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-ia64-devel] [RFC] cleanup warning (redefine MMIO_SIZE), Akio Takebe Re: [Xen-ia64-devel] [RFC] cleanup warning (redefine MMIO_SIZE), Tristan Gingold Re: [Xen-ia64-devel] [RFC] cleanup warning (redefine MMIO_SIZE), Alex Williamson <= Re: [Xen-ia64-devel] [RFC] cleanup warning (redefine MMIO_SIZE), Akio Takebe

Previous by Date:	Re: [Xen-ia64-devel] Re: [Xen-users] XEN on machines with EFI, Rodrigo Lord
Next by Date:	[Xen-ia64-devel] Problems booting dom0, Rodrigo Lord
Previous by Thread:	Re: [Xen-ia64-devel] [RFC] cleanup warning (redefine MMIO_SIZE), Tristan Gingold
Next by Thread:	Re: [Xen-ia64-devel] [RFC] cleanup warning (redefine MMIO_SIZE), Akio Takebe
Indexes:	[Date] [Thread] [Top] [All Lists]