Re: [Xen-ia64-devel] PATCH: remove remaining asm warnings.

On Wed, 2006-04-26 at 17:18 +0200, Tristan Gingold wrote:
> Le Mercredi 26 Avril 2006 17:01, Aron Griffis a écrit :
> > Hi Tristan,
> >
> > This section originally used tabs but you switched to spaces, so the
> > indentation is wonky now.  Would it be better to keep the indentation
> > uniform?
> The first line of this file is:
> /* -*-  Mode:C; c-basic-offset:4; tab-width:4; indent-tabs-mode:nil -*- */
> 
> Therefore spaces must be used!
> 
> What should I do ?

   I generally try to keep formatting consistent w/in a function
regardless of the formatting hints in the file.  I know we have quite a
mix of code in the ia64 tree, but changing it a line at a time just
makes code hard to read.  At some point (not now) we should probably go
through and make it as consistent as we can given that Xen coding style
doesn't match Linux coding style.  Thanks,

        Alex

-- 
Alex Williamson                             HP Linux & Open Source Lab

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-ia64-devel] PATCH: remove remaining asm warnings., Tristan Gingold

Next by Date:

Re: [Xen-ia64-devel] [PATCH 6/9] [P2M/VP step 1] linux: introduce config option, Aron Griffis

Previous by Thread:

Re: [Xen-ia64-devel] PATCH: remove remaining asm warnings., Tristan Gingold

Next by Thread:

[Xen-ia64-devel] Re: PATCH: remove remaining asm warnings., Alex Williamson

Indexes:

[Date] [Thread] [Top] [All Lists]