WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-devel] [PATCH 4/6] grantable and address conversion patches


On 10 Apr 2006, at 13:37, Isaku Yamahata wrote:

I'd rather define a function to fill in the entire structure in
gnttab.h.

I hope that the attached patch is much more preferable
than the previous one.
I tested compilation and dom0 boot.

Is the 'phys' parameter to the new functions ever non-zero?

Also, the call sites that pass a ptep pose a problem -- the host address should not be __pa()'ed as it's already a machine (or pseudo-phys) address. On mapping you can check for GNTMAP_contains_pte. Perhaps we will need to pass flags to the unmap function too.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel