RE: [Xen-ia64-devel] [PATCH] access_reflection fix

[Alex Williamson <alex.williamson@xxxxxx>]

On Thu, 2006-03-30 at 10:29 +0800, Xu, Anthony wrote:
> 
> R22 comes from region register; bit 1 is reserved for region register.
> So bit 1 should 0, VMM only need to reset bit0. 
> Then this patch should be OK,
> -2 are same with ~1 :-).

   Ok, that makes sense then.  It might still be good to clear both bits
just so the operation makes sense wrt to fields of the register.  Please
resubmit and either change the submit comment to reflect the code or the
code the reflect the comment.  fwiw, I tend to prefer the one's
compliment since it makes these mismatches a little more obvious.
Thanks,

        Alex

-- 
Alex Williamson                             HP Linux & Open Source Lab


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel