Re: [Xen-ia64-devel] name conflict(map_domain_page)

[Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>]

Hi, Yamahata and all

I think good sugesstion.
Should map_new_domain0_page()  also be renamed?
How are alloc_xxxx?
(I'm also bad at naming...)

Best Regards,

Akio Takebe

>
>I found that name map_domain_page is defined in two places.
>one is defined in xen/include/xen/domain_page.h.
>another is defined in xen/arch/ia64/xen/domain.c.
>Luckily this name conflict doesn't cause problem for now.
>However this is a bad practice, so it should be fixed.
>The one in xen/include/xen/domain_page.h is used in xen commonly,
>so the one defined in xen/arch/ia64/xen/domain.c should be renamed.
>
>I propose following name changes.
>(Only the name map_domain_page() is conflicted, 
>For consistency others should also be changed.)
>
>map_new_domain_page()  -> assign_new_domain_page()
>map_domain_page()      -> assign_domain_page()
>map_domain_io_page()   -> assign_domain_io_page()
>
>
>I am bad at naming, I hope someone propose better names.
>Any suggenstions?
>Once new names are decided, I will make a patch.
>Or if no objections, I will go with above name.
>
>-- 
>yamahata
>
>_______________________________________________
>Xen-ia64-devel mailing list
>Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-ia64-devel


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel