WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-ia64-devel] RE: PATCH for warnings; was "-Wall" option doesn't work

To: "Tristan Gingold" <Tristan.Gingold@xxxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Xu, Anthony" <anthony.xu@xxxxxxxxx>, <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-ia64-devel] RE: PATCH for warnings; was "-Wall" option doesn't work
From: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
Date: Fri, 13 Jan 2006 06:56:28 -0800
Delivery-date: Fri, 13 Jan 2006 15:03:10 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcYYHzjFTx0pFssLTXijGE7pTMqyYAAMfO0A
Thread-topic: PATCH for warnings; was "-Wall" option doesn't work
Sorry, my mistake.  I tested xen-warn3.diffs but when
I did an "hg commit", for cut-paste of your comments,
I accidentally vi'ed your old xen-warn.diffs file.

Now committed.

> -----Original Message-----
> From: Tristan Gingold [mailto:Tristan.Gingold@xxxxxxxx] 
> Sent: Friday, January 13, 2006 3:00 AM
> To: Magenheimer, Dan (HP Labs Fort Collins); Tian, Kevin; Xu, 
> Anthony; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: PATCH for warnings; was "-Wall" option doesn't work
> 
> Le Vendredi 13 Janvier 2006 00:41, Magenheimer, Dan (HP Labs 
> Fort Collins) a 
> écrit :
> > I tested this patch and was about to commit it but noticed
> > that there was no "Signed-off-by" line.  In support of
> > Kevin's message the other day and Xen patch standards,
> > could I ask you to please resend the patch with a valid
> > "Signed-off-by" line?  If there are no other changes in
> > the patch file, I will commit it without further testing.
> Hi,
> 
> I think I miss something.  There is a Signed-off-by line in the patch:
>   # HG changeset patch
>   # User tristan.gingold@xxxxxxxx
>   # Node ID 34a8366f42ac3347face862e5f59a3f3aeff8589
>   # Parent  1507c5499a92a7701db9cc3b0bf9ac5fb3fa8ee2
>   Enable warnings and fix a few one (those which occur in 
> almost every file).
>   The next step is to fix warnings one by one.
> 
>   Signed-off-by: Tristan Gingold <tristan.gingold@xxxxxxxx>
> 
>   diff -r 1507c5499a92 -r 34a8366f42ac xen/arch/ia64/Rules.mk
>   --- a/xen/arch/ia64/Rules.mk        Fri Jan  6 18:39:28 2006
>   +++ b/xen/arch/ia64/Rules.mk        Thu Jan 12 07:58:30 2006
>   @@ -23,10 +23,10 @@
> Maybe this is the wrong place ?  In the Kevin's message, the 
> place of the
> Signed-off-by line is not very explicit and I thought it 
> should be placed in 
> the patch commit message.
> 
> Tristan.
> 
> 

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

<Prev in Thread] Current Thread [Next in Thread>