RE: [Xen-ia64-devel] [PATCH] [5/6] panic stack trace: adds hook

["Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>]

> > Is the code for break 0x0 just for testing the register
> > dump code?  Isn't it possible for a guest to generate a
> > break 0x0 that should be reflected?  
> 
> No. It handles break 0x0 only issued in ring 0.
> break 0x0 issued in ring non-0 is reflected.

OK, I see, I missed that.  The "break 0" is used
in BUG() via FORCE_CRASH.

> Is there anything wrong with this patch?

No, I was just looking at the code and had that question.

However, it would be helpful if you could resend
the patches as attachments as there is some line wrap
from one of our mailers.  You don't need to break it
into smaller files again, one single patch file
attachment would be fine

BTW, long files do get through eventually, they just
need to be manually approved by the list administrator.

Thanks,
Dan

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel