Re: [Xen-ia64-devel] [PATCH] xentrace buffer alignment

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi, Rob, Kevin,

Thank you for many information and idea.
Sorry, Relpy is late.
I'm poor english, It takes long time to reply.

I'm working to xentrace execution on ia64 now. 
However, The way seems to be steep.

> The alignment directive is necessary there since they're dynamically marked
> on an allocated buf. Or how about adding padding bytes to avoid using compiler
> directive and ifdef? Then, still no need for "t_rec".

Sorry, "t_rec" alignment is mistake. I thought "sizeof(t_rec) = 52 bytes".

The patch was made on Kevin's idea. 
However, I'm worried. When someone adds other members to "t_buf", isn't 
alignment
for ia64 forgotten?

Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Thanks,
 kan

diff -r 51f32d60536b xen/include/public/trace.h
--- a/xen/include/public/trace.h        Fri Nov 18 00:35:14 2005
+++ b/xen/include/public/trace.h        Thu Nov 24 18:04:31 2005
@@ -69,6 +69,7 @@
     unsigned int  prod;      /* Next item to be produced by Xen.           */
     unsigned int  nr_recs;   /* Number of records in this trace buffer.    */
     /* 'nr_recs' records follow immediately after the meta-data header.    */
+    unsigned int  align_buf; /* 8 bytes alignment for ia64                 */
 };
 
 #endif /* __XEN_PUBLIC_TRACE_H__ */


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel