RE: [Xen-ia64-devel] xen on hp rx2600

["Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>]

Committed. 

> -----Original Message-----
> From: Williamson, Alex (Linux Kernel Dev) 
> Sent: Thursday, November 10, 2005 2:08 PM
> To: Tian, Kevin
> Cc: Magenheimer, Dan (HP Labs Fort Collins); 
> xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: RE: [Xen-ia64-devel] xen on hp rx2600
> 
> On Thu, 2005-11-10 at 14:24 +0800, Tian, Kevin wrote:
> 
> > touch_acpi_table is called by dom_fw_init which is always 
> called when
> > construct dom0 unrelated to SMP.
> 
>    Here's the problem, we're only "touching" the first lsapic entry
> because we're passing in NR_CPUS for max_entries.  Therefore we stop
> parsing MADT entries after the first.  We really need to cycle through
> all of them regardless of NR_CPUS.  Patch below.  Thanks,
> 
>       Alex
> 
> -- 
> Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>
> 
> diff -r be53bbe62f2e xen/arch/ia64/xen/dom_fw.c
> --- a/xen/arch/ia64/xen/dom_fw.c      Wed Nov  9 21:31:01 2005
> +++ b/xen/arch/ia64/xen/dom_fw.c      Thu Nov 10 14:02:31 2005
> @@ -466,11 +466,8 @@
>  /* base is physical address of acpi table */
>  void touch_acpi_table(void)
>  {
> -     u64 count = 0;
> -     count = acpi_table_parse_madt(ACPI_MADT_LSAPIC, 
> acpi_update_lsapic, NR_CPUS);
> -     if ( count < 1)
> +     if (acpi_table_parse_madt(ACPI_MADT_LSAPIC, 
> acpi_update_lsapic, 0) < 0)
>               printk("Error parsing MADT - no LAPIC entires\n");
> -     printk("Total %d lsapic entry\n", count);
>       acpi_table_parse(ACPI_APIC, acpi_update_madt_checksum);
>  
>       return;
> 
> 
> 

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel