RE: [Xen-ia64-devel] [Patch] tools build patch for gcc3.4

[takebe_akio@xxxxxxxxxxxxxx]

Hi Dan,

It is patch to avoid double defines "struct ia64_fpreg".

I have the following error today.
-----------------------
gcc   -Wall -Werror -O3 -fno-strict-aliasing  -I. -Wp,-MD,.
xc_linux_build.o.d -c -o xc_linux_build.o xc_linux_build.c
In file included from xc_linux_build.c:294:
/usr/include/asm/fpu.h:57: error: redefinition of `struct ia64_fpreg'
make[3]: *** [xc_linux_build.o] Error 1
make[3]: Leaving directory `/root/new/xen-ia64-unstable.hg/tools/libxc'
make[2]: *** [build] Error 2
make[2]: Leaving directory `/root/new/xen-ia64-unstable.hg/tools/libxc'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/root/new/xen-ia64-unstable.hg/tools'
make: *** [install-tools] Error 2
---------------------------

I found the define "struct ia64_fpreg" in /usr/include/bits/sigcontext.h 
call from xg_private.h
           -> xenctrl.h 
             ->/usr/include/sys/ptrace.h 
              -> /usr/include/sys/ptrace.h 
               ->/usr/include/signal.h.
So I move asm/fpu.h to first line together "#ifdef __ia64__".
At this time, I use "#define __ASSEMBLY__" because of not defining 
"struct ia64_fpreg" in asm/fpu.h.

But __IA64UL and __IA64_UL_CONST in asm/types.h called from asm/fpu.h
is different define by defining __ASSEMBLY__.
So I redefine __IA64UL and __IA64_UL_CONST correctly.

Best Regards,

Akio Takebe

>Is there a cleaner way of doing this?   This is a common
>file (shared with Xen/x86) and I don't think Keir will like
>this patch.  Why is __ASSEMBLY__ turned on?  (it should only
>be turned on when compiling assembly code)  And why do
>__IA64_UL and __IA64_UL_CONST need to be redefined?
>
>Thanks,
>Dan
>
>> -----Original Message-----
>> From: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx 
>> [mailto:xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf 
>> Of takebe_akio@xxxxxxxxxxxxxx
>> Sent: Thursday, November 17, 2005 6:33 AM
>> To: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
>> Subject: [Xen-ia64-devel] [Patch] tools build patch for gcc3.4
>> 
>> Hi,
>> 
>> I and Kanno made a tools build patch for gcc3.4.
>> I test it work on RHEL4 and Xen.
>> I confirmed to be able to compile tools on RHEL3,
>> but still don't test it works on RHEL3 and Xen.
>> 
>> Signed-off-by Akio Takabe <takebe_akio@xxxxxxxxxxxxxx>
>> Signed-off-by Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
>> 
>> Best Regards,
>> 
>> Akio Takebe 
>> 

◇◇◇----------------------------------------------------◇◇◇
        富士通株式会社　サーバシステム事業本部　
        　　Ｌｉｎｕｘソフトウェア開発統括部
　               竹部　晶雄(Takebe Akio)　★B6Fに移りました。
        外線:055-924-7241(内線:7551-5364) Fax:055-924-6196
          mailto:takebe_akio@xxxxxxxxxxxxxx
◇◇◇----------------------------------------------------◇◇◇


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel