On Mon, Oct 24, 2005 at 09:19:33AM +0800, Tian, Kevin wrote:
> >From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
> >
> >The patches look okay, although the Python bits aren't particularly
> >pretty.
> >
> > -- Keir
>
> Sorry for bad Python skill. ;-) So Dan, please help check in.
Actually executing your code would be a good start.
--- a/tools/python/xen/xend/image.py Sat Oct 15 03:09:43 2005
+++ b/tools/python/xen/xend/image.py Fri Oct 21 15:35:26 2005
@@ -58,6 +58,7 @@
"""
ostype = None
+ page_kb = 4
def __init__(self, vm, imageConfig, deviceConfig):
@@ -366,11 +367,13 @@
def getDomainMemory(self, mem):
"""@see ImageHandler.getDomainMemory"""
+ if os.uname[4] == 'ia64':
+ page_kb = 16
# for ioreq_t and xenstore
static_pages = 2
This is going to fail with a TypeError exception, because os.uname is a
function. You want os.uname()[4].
Ewan.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home