[Xen-ia64-devel] RE: [PATCH long & boring]: compile with -Wall -Werror

["Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>]

Hi Tristan --

Although I appreciate the value of avoiding compile warnings,
your patch requires many changes to about 20 files that are
identical to or heavily leveraged from linux files**.   I am
hesitant to make that many changes for compile-time
convenience as it will make maintenanace much harder when
keeping up with new Linux releases.

If you can rework the patch with fewer changes to linux-leveraged
files, I would consider applying it.  For example, I see lots
of new includes of xen/lib.h... can that be moved to a single
header file (preferably non-leveraged) to avoid so many
changes?  There may be other tricks like this to minimize
the changes...

Also, please submit bug fixes as separate patches as they
are hard to examine when bundled with many other syntactic
and formatting changes.

Thanks,
Dan

** find xen -name 'README.origin'

> -----Original Message-----
> From: Tristan Gingold [mailto:Tristan.Gingold@xxxxxxxx] 
> Sent: Wednesday, October 19, 2005 9:47 AM
> To: Magenheimer, Dan (HP Labs Fort Collins)
> Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
> Subject: [PATCH long & boring]: compile with -Wall -Werror
> 
> Hi,
> 
> here is a long and boring patch which fixes misc issues.  It 
> also enables 
> warnings and makes warnings to errors.
> 
> This is not yet perfect: I think there should be no 'extern' 
> declarations in C 
> files.  An extra effort is necessary for that.
> 
> Also I think I have caught a few potential bugs: see 
> vmx_hypercall.c and 
> irq.c.
> 
> Tristan.
> 

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel