|
|
|
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] [PATCH 1/3] xen/granttable: Introducing grant table V2 s
To: |
ANNIE LI <annie.li@xxxxxxxxxx> |
Subject: |
Re: [Xen-devel] [PATCH 1/3] xen/granttable: Introducing grant table V2 stucture |
From: |
Ian Campbell <Ian.Campbell@xxxxxxxxxx> |
Date: |
Fri, 18 Nov 2011 10:54:49 +0000 |
Cc: |
"jeremy@xxxxxxxx" <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "kurt.hackel@xxxxxxxxxx" <kurt.hackel@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Paul Durrant <Paul.Durrant@xxxxxxxxxx> |
Delivery-date: |
Fri, 18 Nov 2011 02:56:04 -0800 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<4EC62E77.7090007@xxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
Organization: |
Citrix Systems, Inc. |
References: |
<4EC3B62F.6080702@xxxxxxxxxx> <1321451304-13559-1-git-send-email-annie.li@xxxxxxxxxx> <4EC62E77.7090007@xxxxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Thanks for splitting these up.
On Fri, 2011-11-18 at 10:07 +0000, ANNIE LI wrote:
> [...]
> return value
> + * by bit operations.
> + */
> + int (*query_foreign_access)(grant_ref_t);
> +};
> +
> +static struct gnttab_ops gnttab_v1_ops;
You don't actually need this forward declaration since the struct
definition and usage are ordered correctly.
> +static struct gnttab_ops gnttab_v1_ops = {
> + .map_frames = gnttab_map_frames_v1,
> + .unmap_frames = gnttab_unmap_frames_v1,
> + .update_entry = update_grant_entry_v1,
Any reason this one is not gnttab_foo?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|