Re: [Xen-devel] [PATCH 2/4] docs/html/hcall: Annotations for two hypercalls

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sun, 2011-11-13 at 19:21 +0000, Ian Jackson wrote:
> diff --git a/xen/include/xen/errno.h b/xen/include/xen/errno.h
> index 7cf599f..c2eb5d3 100644
> --- a/xen/include/xen/errno.h
> +++ b/xen/include/xen/errno.h
> @@ -1,6 +1,9 @@
>  #ifndef _I386_ERRNO_H
>  #define _I386_ERRNO_H
>  
> +/* ` enum neg_errnoval { /* -Efoo for each Efoo in the list below } */

Do we pass -Wcomment (or something which includes it)? If so gcc might
warn:
        /home/ianc/t.c:5:26: warning: "/*" within comment
(and we use -Werror, so...).

Is this syntax trying to encode some meaning or was it just a typo?

> +/* ` enum errnoval { */
> +
>  #define      EPERM            1      /* Operation not permitted */
>  #define      ENOENT           2      /* No such file or directory */
>  #define      ESRCH            3      /* No such process */
> @@ -129,4 +132,6 @@
>  #define      ENOMEDIUM       123     /* No medium found */
>  #define      EMEDIUMTYPE     124     /* Wrong medium type */
>  
> +/* } */

Is the ` supposed to be required here or is omitting it fine?

> +
>  #endif



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel