xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH 8/9] Decompressors: check for write errors in unlzo.c

from [Jan Beulich]

[Permanent Link][Original]

To:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH 8/9] Decompressors: check for write errors in unlzo.c
From:	"Jan Beulich" <JBeulich@xxxxxxxx>
Date:	Fri, 11 Nov 2011 11:31:42 +0000
Cc:	lasse.collin@xxxxxxxxxxx
Delivery-date:	Fri, 11 Nov 2011 03:34:51 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

From: Lasse Collin <lasse.collin@xxxxxxxxxxx>

The return value of flush() is not checked in unlzo().  This means that
the decompressor won't stop even if the caller doesn't want more data.
This can happen e.g.  with a corrupt LZO-compressed initramfs image.

Signed-off-by: Lasse Collin <lasse.collin@xxxxxxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/common/unlzo.c
+++ b/xen/common/unlzo.c
@@ -202,8 +202,8 @@ STATIC int INIT unlzo(u8 *input, unsigne
                        }
                }
 
-               if (flush)
-                       flush(out_buf, dst_len);
+               if (flush && flush(out_buf, dst_len) != dst_len)
+                       goto exit_2;
                if (output)
                        out_buf += dst_len;
                if (posp)

unlzo-check-write-errors.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH 8/9] Decompressors: check for write errors in unlzo.c, Jan Beulich <=

Previous by Date:	[Xen-devel] [PATCH 7/9] Decompressors: validate match distance in unlzma.c, Jan Beulich
Next by Date:	[Xen-devel] [PATCH 9/9] Decompressors: check input size in unlzo.c, Jan Beulich
Previous by Thread:	[Xen-devel] [PATCH 7/9] Decompressors: validate match distance in unlzma.c, Jan Beulich
Next by Thread:	[Xen-devel] [PATCH 9/9] Decompressors: check input size in unlzo.c, Jan Beulich
Indexes:	[Date] [Thread] [Top] [All Lists]