WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: performance regression from c/s 21647:cfba1560054a

To: Jan Beulich <JBeulich@xxxxxxxx>
Subject: [Xen-devel] Re: performance regression from c/s 21647:cfba1560054a
From: Gianluca Guida <glguida@xxxxxxxxx>
Date: Thu, 10 Nov 2011 07:27:22 -0800
Cc: Gianluca Guida <gianluca.guida@xxxxxxxxxx>, "Tim \(Xen.org\)" <tim@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 10 Nov 2011 07:44:52 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=pMH3HX3RPHZ6kVOxibRMMfv1YEcx7blHntq5Zq5semw=; b=npHv7VXMFUOMQFSyKibHWzLfYlExP8LtlhtO5BZaVwEmn1tCcTlpg5xqRnWOrqdiuB FobwaN8Ayy8ZRTIv+lo5sNjakQ6o2e8c+rQpS2FZZP2kDtIsoE3ztfkgum66aagrexRK 4/qRu0lIoqE6ZDU0wV4cH40ynhqxBH0mCO/WY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4EBBF87102000078000603A1@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4EBBC25B02000078000601F1@xxxxxxxxxxxxxxxxxxxx> <CAKpvNa3DmeQyXBb7obc_PbsNaEUBLjTFc_eLkTKH8RwYs4WQYw@xxxxxxxxxxxxxx> <4EBBF36A0200007800060375@xxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1111101457380.3519@kaball-desktop> <CAKpvNa1sPPjVyzPWbrdBhEe5i1ji6fwg6CDSx-QPyz5LjywpnQ@xxxxxxxxxxxxxx> <4EBBF87102000078000603A1@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, Nov 10, 2011 at 7:14 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 10.11.11 at 16:00, Gianluca Guida <glguida@xxxxxxxxx> wrote:
>> On Thu, Nov 10, 2011 at 6:59 AM, Stefano Stabellini
>> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
>>> On Thu, 10 Nov 2011, Jan Beulich wrote:
>>>> It's SLE11 SP1 guests that suffered a regression after a maintenance
>>>> update (originally shipped with 4.0.0, while that patch got backported
>>>> later into 4.0.x).
>>>
>>> Is SLES11 SP1 using HVMOP_pagetable_dying (see
>>> arch/x86/xen/mmu.c:xen_hvm_init_mmu_ops)?
>>
>> Good question. In case it does not, just changing the ">l1" check to
>> work only in case we used the hypercall might do the trick.
>
> Possibly, though I would argue that the difference between Linuxes
> shouldn't be that big (i.e. I would rather expect that pv-on-hvm
> guests also see a performance penalty here).

No, because what the patch does is to unshadow the user pagetables
(all levels) as soon as the hypercall is made (when the kernel is
destroying the process). check_for_early_unshadow(), when the
hypercall is used, is for removing the pagetables that maps some
process-specific non-user mappings.

Importing the hypercall is a good idea, but fixing the logic would
help linux guests not using the hypercall.

Gianluca

-- 
It was a type of people I did not know, I found them very strange and
they did not inspire confidence at all. Later I learned that I had been
introduced to electronic engineers.
                                                  E. W. Dijkstra

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel