WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] x86/MSI: fix dump_msi() after c/s 24068:6928172f7ded

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] x86/MSI: fix dump_msi() after c/s 24068:6928172f7ded
From: "Jan Beulich" <JBeulich@xxxxxxxx>
Date: Tue, 08 Nov 2011 16:54:34 +0000
Delivery-date: Tue, 08 Nov 2011 08:55:40 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
The function must not blindly take the lock on IRQ descriptors.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

--- a/xen/arch/x86/msi.c
+++ b/xen/arch/x86/msi.c
@@ -1076,6 +1076,9 @@ static void dump_msi(unsigned char key)
         unsigned long flags;
         char type;
 
+        if ( !irq_desc_initialized(desc) )
+            continue;
+
         spin_lock_irqsave(&desc->lock, flags);
 
         entry = desc->msi_desc;



Attachment: x86-dump_msi-locking.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] x86/MSI: fix dump_msi() after c/s 24068:6928172f7ded, Jan Beulich <=