WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [PATCH 1/6] vtd: Refactor iotlb flush code

To: Jean Guyader <jean.guyader@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH 1/6] vtd: Refactor iotlb flush code
From: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Date: Mon, 7 Nov 2011 19:10:04 -0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "tim@xxxxxxx" <tim@xxxxxxx>
Delivery-date: Mon, 07 Nov 2011 19:11:03 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1320690327-12649-2-git-send-email-jean.guyader@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1320690327-12649-1-git-send-email-jean.guyader@xxxxxxxxxxxxx> <1320690327-12649-2-git-send-email-jean.guyader@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcyderFEU9hqUw51Q+qajadXxWtcSAASNsSA
Thread-topic: [PATCH 1/6] vtd: Refactor iotlb flush code
Jean,

The original code does not call iommu_flush_iotlb_dsi().  What is the reason 
the refractored code need to use domain selective invalidation?

Allen
-----

+        if ( page_count > 1 || gfn == -1 )
+        {
+            if ( iommu_flush_iotlb_dsi(iommu, iommu_domid,
+                        0, flush_dev_iotlb) )
+                iommu_flush_write_buffer(iommu);
+        }
+        else
+        {
+            if ( iommu_flush_iotlb_psi(iommu, iommu_domid,
+                        (paddr_t)gfn << PAGE_SHIFT_4K, 0,
+                        !dma_old_pte_present, flush_dev_iotlb) )
+                iommu_flush_write_buffer(iommu);

-----Original Message-----
From: Jean Guyader [mailto:jean.guyader@xxxxxxxxxxxxx] 
Sent: Monday, November 07, 2011 10:25 AM
To: xen-devel@xxxxxxxxxxxxxxxxxxx
Cc: tim@xxxxxxx; Kay, Allen M; Jean Guyader
Subject: [PATCH 1/6] vtd: Refactor iotlb flush code


Factorize the iotlb flush code from map_page and unmap_page into it's own 
function.

Signed-off-by: Jean Guyader <jean.guyader@xxxxxxxxxxxxx>
---
 xen/drivers/passthrough/vtd/iommu.c |   86 +++++++++++++++++-----------------
 1 files changed, 43 insertions(+), 43 deletions(-)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>