WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH RFC v2 06/13] libxl: permit declaration after sta

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH RFC v2 06/13] libxl: permit declaration after statement
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 7 Nov 2011 10:43:07 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Mon, 07 Nov 2011 02:44:28 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1320263024.3084.61.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1319827031-15395-1-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-2-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-3-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-4-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-5-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-6-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1319827031-15395-7-git-send-email-ian.jackson@xxxxxxxxxxxxx> <1320054652.23193.28.camel@xxxxxxxxxxxxxxxxxxxxxx> <20145.29085.278257.629473@xxxxxxxxxxxxxxxxxxxxxxxx> <1320263024.3084.61.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Wed, 2 Nov 2011, Ian Campbell wrote:
> On Wed, 2011-11-02 at 12:36 -0400, Ian Jackson wrote:
> > Ian Campbell writes ("Re: [Xen-devel] [PATCH RFC v2 06/13] libxl: permit 
> > declaration after statement"):
> > > I suspect there isn't much scope for abuse of this capability but would
> > > a few words of guidance in CODING_STYLE make sense?
> > 
> > I don't think there's anything I feel needs saying.  If you think
> > people are likely to abuse it in a particular way then do say :-).
> > 
> > Otherwise we can wait and see what results and add stuff to
> > CODING_STYLE as necessary ?
> 
> Yes, lets do that.
> 

I think it would make sense to add to the CODING_STYLE that variable
declarations shouldn't be mixed with code, unless part of a macro or an
alloca-like construct.
Basically the coding style should stay the same that is now.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>