WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel]xl create PV guest with qcow/qcow2 disk images fail

To: Chunyan Liu <cyliu@xxxxxxxx>
Subject: Re: [Xen-devel]xl create PV guest with qcow/qcow2 disk images fail
From: Roger Pau Monné <roger.pau@xxxxxxxxxxxxx>
Date: Fri, 4 Nov 2011 10:14:47 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 04 Nov 2011 02:15:52 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=3kjFFiR0EcW2ZOLkPbHO+PFQ4SN2L2UDcLnbVVFzSBc=; b=strT0KU4NZUY09qXQWrjZD+REdaB2m46rqmIfQeGcBz4IWCkRm248vsK/TNC1N4Ihm SmW0Moe2ZbN02YTi1eJ7lnq1cltVgpL0hlZzkkwBL0ImRaWde5J8w5ttnUDnS5i7lnaZ tz7DxaFuSs2svZ4oLr2DxS70qNm7P06sMbx6E=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CAERYnoaMLUcY_mr=+S86kj4=0RBk5-smUNpxRzOrpGPHtoCh+A@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1319808450-9617-1-git-send-email-cyliu@xxxxxxxx> <4EB184DE020000660000603E@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <1320238770.3084.51.camel@xxxxxxxxxxxxxxxxxxxxxx> <CAERYnoaMLUcY_mr=+S86kj4=0RBk5-smUNpxRzOrpGPHtoCh+A@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
2011/11/4 Chunyan Liu <cyliu@xxxxxxxx>:
>> This needs to be libxl_fork, I think. Perhaps even this whole thing
>> should be libxl__spawn_spawn (not sure about that)?
>
> I noticed that in libxl, some places use fork() and other places use
> libxl_fork(), device-model uses libxl__spawn_spwan. As for this place, I am
> not clear if fork() + execvp() might cause some problem? Or it is just
> considered better to use libxl_fork or libxl__spawn_spwan?

If you are going to use fork to execute a file it might be best to use
vfork + libxl__exec instead. I have proposed the addition of a new
function in a patch to just do this (call vfork and libxl__exec),
which is also interesting for the execution of hotplug scripts.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel