Re: [Xen-devel] [PATCH 0/3] x86/microcode: support for microcode

On 11/03/2011 08:06 AM, Ben Guthro wrote:
> After pulling in this change from your tree, I found the following
> bug, when checking an enum value, which should be considered before
> inclusion:
>
>
> diff --git a/arch/x86/kernel/microcode_xen.c
> b/arch/x86/kernel/microcode_xen.c
> index 9d2a06b..6a73957 100644
> --- a/arch/x86/kernel/microcode_xen.c
> +++ b/arch/x86/kernel/microcode_xen.c
> @@ -157,7 +157,7 @@ static enum ucode_state
> xen_request_microcode_user(int cpu,
>  ret = UCODE_OK;
>  
>  out:
> -if (ret == 0)
> +if (ret == UCODE_OK)
>  uci->mc = uc;
>  else
>  vfree(uc);

Thanks!

    J


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [Xen-devel] [PATCH 0/3] x86/microcode: support for microcode update in Xen dom0, Ben Guthro Re: [Xen-devel] [PATCH 0/3] x86/microcode: support for microcode update in Xen dom0, Jeremy Fitzhardinge <=

Previous by Date:

Re: [Xen-devel] [PATCH 3 of 5] ats: Add new ATS helper functions, Jan Beulich

Next by Date:

Re: [Xen-devel] [PATCH 2 of 5] amd iommu: Fix iommu page size encoding when page order > 0, Wei Wang2

Previous by Thread:

Re: [Xen-devel] [PATCH 0/3] x86/microcode: support for microcode update in Xen dom0, Ben Guthro

Next by Thread:

[Xen-devel] [PATCH v2] powernow: don't read never initialoized structure member, Jan Beulich

Indexes:

[Date] [Thread] [Top] [All Lists]