WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 9 of 9] Modify all call sites of queries into the

To: "Tim Deegan" <tim@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH 9 of 9] Modify all call sites of queries into the p2m to use the new fine-grained locking
From: "Andres Lagar-Cavilla" <andres@xxxxxxxxxxxxxxxx>
Date: Thu, 3 Nov 2011 08:20:02 -0700
Cc: andres@xxxxxxxxxxxxxxxx, olaf@xxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, andres@xxxxxxxxxxxxxx, keir.xen@xxxxxxxxx, Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>, adin@xxxxxxxxxxxxxx
Delivery-date: Thu, 03 Nov 2011 08:22:59 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed; d=lagarcavilla.org; h= message-id:in-reply-to:references:date:subject:from:to:cc :reply-to:mime-version:content-type:content-transfer-encoding; s=lagarcavilla.org; bh=LzQ8RI8IaMMduoaFMPjXYAjtV6o=; b=D/rvMgid AmA8gpxweaOLm2ELUhzsfJjHKzBiIfrf2WRFfosZtdMwb4Y6B5St0SQ3zRp7ir4A OVlmB7v+OE5GdgEYhdzUgn9Ds4jSyplqVzBsAHUfcPwWzLmzNo37KZzCJx+Jl8KF 8hJO/QEg9VrE9Mvn22qC/zfiZbKzalPZPz4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=lagarcavilla.org; h=message-id :in-reply-to:references:date:subject:from:to:cc:reply-to :mime-version:content-type:content-transfer-encoding; q=dns; s= lagarcavilla.org; b=p0mtYpJEU91Uwrj8dEuMAx2UiZ0THuXBoldsLIyeRAX1 eGZPZJCupK/O0BhbMeueXmjT8DmSzfuWohKGX2NgbxQlBsHB/9qBgFax/WCu70zF 4bpjWaIqWX6xuIO+TaIK/Ksmut2QrD8jPQ8qPoQLBQwO9q9ROVCfBvl88J1A/y8=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20111103143805.GF66800@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1319690025@xxxxxxxxxxxxxxxxxxx> <d13f91c2fe18d58ad27f.1319690034@xxxxxxxxxxxxxxxxxxx> <20111027150207.GO59656@xxxxxxxxxxxxxxxxxxxxx> <2edecee6fa102acb9973b1ef1e71a65d.squirrel@xxxxxxxxxxxxxxxxxxxxxxxx> <20111103143805.GF66800@xxxxxxxxxxxxxxxxxxxxx>
Reply-to: andres@xxxxxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: SquirrelMail/1.4.21
get_gfn/put_gfn it is. I'll figure set_gfn/alternative on the way. Next
patch coming with that naming. It will make everyone cringe :)

Andres

> At 07:32 -0700 on 02 Nov (1320219175), andres@xxxxxxxxxxxxxxxx wrote:
>> I don't know that a massive sed on all these names is a good idea. I
>> guess
>> forcing everyone to compile-fail will also make them realize they need
>> to
>> add a call to drop the p2m locks they got...
>>
>> Can you elaborate on the naming preferences here: would you prefer
>> gfn_to_mfn/put_gfn? get_p2m_gfn/put_p2m_gfn? get_gfn/put_gfn
>
> I think I'd prefer get_gfn/put_gfn.  And maybe set_gfn for writes too?
> But I'm willing to be persuaded otherwise if anyone feels strongly about
> it.
>
> Tim.
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>