WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2 of 6] ats: Remove VTD prefix from debug output

To: "Wei Wang" <wei.wang2@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 6] ats: Remove VTD prefix from debug output
From: "Jan Beulich" <JBeulich@xxxxxxxx>
Date: Wed, 02 Nov 2011 13:42:41 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 02 Nov 2011 06:43:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <0d17087f9e495c1b9eb4.1319548054@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1319548052@xxxxxxxxxxxx> <0d17087f9e495c1b9eb4.1319548054@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 25.10.11 at 15:07, Wei Wang <wei.wang2@xxxxxxx> wrote:
> # HG changeset patch
> # User Wei Wang <wei.wang2@xxxxxxx>
> # Date 1319472689 -7200
> # Node ID 0d17087f9e495c1b9eb43bc0f6a21319097f3043
> # Parent  217c4a82b202975c2fdff9ae499f065471e5c87b
> ats: Remove VTD prefix from debug output.

Personally I would prefer if you folded this into patch 1.

Jan

> Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
> 
> diff -r 217c4a82b202 -r 0d17087f9e49 xen/drivers/passthrough/x86/ats.c
> --- a/xen/drivers/passthrough/x86/ats.c       Mon Oct 24 18:11:23 2011 +0200
> +++ b/xen/drivers/passthrough/x86/ats.c       Mon Oct 24 18:11:29 2011 +0200
> @@ -58,7 +58,7 @@ int enable_ats_device(int seg, int bus, 
>      BUG_ON(!pos);
>  
>      if ( iommu_verbose )
> -        dprintk(XENLOG_INFO VTDPREFIX,
> +        dprintk(XENLOG_INFO,
>                  "%04x:%02x:%02x.%u: ATS capability found\n",
>                  seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
>  
> @@ -99,7 +99,7 @@ int enable_ats_device(int seg, int bus, 
>      }
>  
>      if ( iommu_verbose )
> -        dprintk(XENLOG_INFO VTDPREFIX,
> +        dprintk(XENLOG_INFO,
>                  "%04x:%02x:%02x.%u: ATS %s enabled\n",
>                  seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn),
>                  pos ? "is" : "was");
> @@ -133,7 +133,8 @@ void disable_ats_device(int seg, int bus
>      }
>  
>      if ( iommu_verbose )
> -        dprintk(XENLOG_INFO VTDPREFIX,
> +        dprintk(XENLOG_INFO,
>                  "%04x:%02x:%02x.%u: ATS is disabled\n",
>                  seg, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
>  }
> +
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx 
> http://lists.xensource.com/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] [PATCH 2 of 6] ats: Remove VTD prefix from debug output, Jan Beulich <=