WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] pm : provide CC7/PC2 residency

To: "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pm : provide CC7/PC2 residency
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Wed, 2 Nov 2011 10:56:38 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
Delivery-date: Wed, 02 Nov 2011 02:58:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <749B9D3DBF0F054390025D9EAFF47F2212D5AEEE4A@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <749B9D3DBF0F054390025D9EAFF47F2212D2A848E5@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4EB11212020000780005E5F5@xxxxxxxxxxxxxxxxxxxx> <749B9D3DBF0F054390025D9EAFF47F2212D5AEEE4A@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; NetBSD amd64; en-US; rv:1.9.2.17) Gecko/20110523 Lightning/1.0b3pre Thunderbird/3.1.10
On 11/02/11 10:48, Zhang, Yang Z wrote:
From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
On 25.10.11 at 15:34, "Zhang, Yang Z"<yang.z.zhang@xxxxxxxxx>  wrote:
--- a/xen/include/public/sysctl.h       Mon Oct 24 18:01:07 2011 +0100
+++ b/xen/include/public/sysctl.h       Fri Oct 28 21:33:07 2011 +0800
@@ -225,11 +225,13 @@
      uint64_aligned_t idle_time;                 /* idle time from boot */
      XEN_GUEST_HANDLE_64(uint64) triggers;    /* Cx trigger counts */
      XEN_GUEST_HANDLE_64(uint64) residencies; /* Cx residencies */
+    uint64_aligned_t pc2;
      uint64_aligned_t pc3;
      uint64_aligned_t pc6;
      uint64_aligned_t pc7;
      uint64_aligned_t cc3;
      uint64_aligned_t cc6;
+    uint64_aligned_t cc7;
  };

  struct xen_sysctl_get_pmstat {

Structure layout changes like this should be accompanied by a bump of
XEN_SYSCTL_INTERFACE_VERSION - is there any reason not to do so in this case?
Can you explain what's the problem? Are you mean new xen with old tools will 
have problem or anything else?

The problem is API/ABI backward-compatibility.

Christoph

--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel