Re: [Xen-devel] [PATCH] libxl: Include a version of bsd's queue.h

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2011-10-26 at 09:14 +0100, Christoph Egger wrote:
> On 10/25/11 19:58, Ian Jackson wrote:
> > Ian Jackson writes ("[Xen-devel] [PATCH] libxl: Include a version of bsd's 
> > queue.h"):
> >> We would like some linked list macros which are (a) well known to be
> >> sane and (b) typesafe.  BSD's queue.h meets these criteria.
> >>
> >> The files in this changeset were obtained with:
> >>    svn co -r 221843 svn://svn.freebsd.org/base/head/sys/sys/
> >>    svn co -r 221843 svn://svn.freebsd.org/base/head/share/man/man3
> >
> > I posted this because I noticed (too late) that libxl_qmp.c includes
> > <sys/queue.h>  and uses some macros that are only available in some
> > queue.h versions.  This is not ideal for portability of course.
> >
> > I think it would be good to include this massaged queue.h and use it
> > in libxl_qmp.c.
> 
> These headers cause build errors on *BSD due to collisions with the
> native headers. Two solutions:
> 
> - Only use them on platforms where they do not exist
> - Add a namespace prefix to the macros and use them consequently

Ian provided a script which adds a namespace to these files at build
time, or at least was supposed to. If it isn't working properly then we
need to see the actual failures you are seeing.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel