WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH][RFC][0/2] x86 SMP: enables core-pair topolog

To: Wei Huang <wei.huang2@xxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH][RFC][0/2] x86 SMP: enables core-pair topology detection for AMD CPUs
From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Date: Fri, 21 Oct 2011 11:31:58 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Fri, 21 Oct 2011 03:32:57 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ZjgiBWuIrj3LyQLYre5tmdWxAizdP2p0cPvUl+UjJgQ=; b=FVMpt6CA8j43M4qtYhskhEc+UE+MFhAJ2nRaL67O1loNfm20FFyZTdDpHco855WuWE 9i5P4eol5GyAdf+OcsEUxpz1wsov/h/Ic+Myz7fP3BfZLZgFxAa3Fe0SRA+ScBN0OPjg UXetBlwbvHfUTNaPezOlcCBkUYy7fBVhjTUdk=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4E08BD2D.9020403@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4E03C386.9030009@xxxxxxx> <4E0862520200007800049BDB@xxxxxxxxxxxxxxxxxxxx> <4E08BD2D.9020403@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Sorry for the late request -- should these patches be back-ported to
4.1.2?  Otherwise anyone using AMD Magny-cours may have a significant
performance hit when using 4.1.

 -George

On Mon, Jun 27, 2011 at 6:26 PM, Wei Huang <wei.huang2@xxxxxxx> wrote:
> Thanks, Jan and George. I attach the latest version which fixes the
> indentation issues.
>
> -Wei
>
>
> On 06/27/2011 03:58 AM, Jan Beulich wrote:
>>>>>
>>>>> On 24.06.11 at 00:51, Wei Huang<wei.huang2@xxxxxxx>  wrote:
>>>
>>> Hi,
>>>
>>> The following two patches enable core-pair topology detection for AMD
>>> CPUs. The main idea is to record compute unit information into
>>> cpuinfo_x86 and use it when building sibling map. The sibling map will
>>> be used by Xen credit scheduler to coordinate VCPU scheduling in a
>>> fashion similar to SMT. This code is very similar to upstream Linux
>>> kernel.
>>>
>>> Regarding the performance improvement, I saw ~8% improvement running
>>> kernel compilation on Dom0 with this patch. Anrea Przywara ran a POVRay
>>> benchmark using this patch and he saw ~5% improvement. No perf
>>> degradation was seen so far.
>>>
>>> Please review.
>>
>> Apart from some indentation issues these look fine to me.
>>
>> Jan
>>
>>> Thanks,
>>> -Wei
>>
>>
>>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] Re: [PATCH][RFC][0/2] x86 SMP: enables core-pair topology detection for AMD CPUs, George Dunlap <=