On Wed, 2011-10-19 at 11:22 +0100, Roger Pau Monné wrote:
> > + xs_watch(ctx->xsh, state_path, be_path);
> > + libxl__device_destroy_tapdisk(gc, be_path);
> > +
> > + if (wait) {
> > + struct timeval tv;
> > + tv.tv_sec = LIBXL_DESTROY_TIMEOUT;
> > + tv.tv_usec = 0;
> > + (void)wait_for_dev_destroy(gc, &tv);
>
> I think we should check the return value of wait_for_dev_destroy here,
> since it might timeout, and the device is not removed then, so
> libxl__device_remove should return 1 in that case (whereas it always
> returns 0 now in that case, even when the device is still being
> watched).
Sure, didn't you post such a patch recently?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home