WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tools/check: check for headers and libraries in

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools/check: check for headers and libraries in EXTRA_INCLUDES and EXTRA_LIB
From: Roger Pau Monné <roger.pau@xxxxxxxxxxxxx>
Date: Wed, 19 Oct 2011 10:13:26 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 19 Oct 2011 01:14:07 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=bwoAaVXX3iLczq0iefSB9VGCU+LjOwnpNSbNhBoLf7A=; b=Cee2eGx/KmoUewnEJ4ds60KsDanAcQPqMbbJUWfZg711n8yYHTNZRhA6G7/3ARBShJ VxLv3dtoX2HyuIv24V7gYCrdE74VESszJSy/QVhsxYSRcbMIQY5LfbT+NQW04YwQLv+Y JNo0qKJC64OvVw1Dzr8AN/WRgCE0uZitQJv+8=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CAPLaKK71zs+0aPd2A6yM_+OPtEfMJZnK2KyHANFxFXgDjms8qQ@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <8fe2ca552de44aa679be.1318512275@loki> <20124.19527.706498.819017@xxxxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK6=nU4R62KvxK++XGNx0zff89TNYZkTFizZ1wDbMqUBNg@xxxxxxxxxxxxxx> <20125.32034.710835.32455@xxxxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK71zs+0aPd2A6yM_+OPtEfMJZnK2KyHANFxFXgDjms8qQ@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>> Why do you move it ?
>
> Because if I found the requested headers in one of the folders while
> doing the for loop I perform a return 0, I could also perform a break
> and left the check_sys_root at the end, but does it really matter that
> much to check_sys_root at the start or at the end of has_header?
> Looking at the code of the function it doesn't seem to matter when it
> is performed.
>

Also, I've forgot to say that has_lib function performs check_sys_root
at the beginning.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel