WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 08 of 27 v2] libxl: do not read f.e. xenstore dir

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 08 of 27 v2] libxl: do not read f.e. xenstore dir in disk list function
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Mon, 17 Oct 2011 15:23:24 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 17 Oct 2011 07:23:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20124.14744.968507.150104@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1318499605@xxxxxxxxxxxxxxxxxxxxx> <c6c7a393fe4a6223df69.1318499613@xxxxxxxxxxxxxxxxxxxxx> <20124.14744.968507.150104@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2011-10-17 at 15:20 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH 08 of 27 v2] libxl: do not read f.e. 
> xenstore dir in disk list function"):
> > libxl: do not read f.e. xenstore dir in disk list function
> > 
> > Instead store a duplicate of the "device-type" node in the backend dir
> > and use that instead.
> > 
> > This maintains the invariant that the list function is always "safe".
> > 
> > XXX I'm not sure this is an actual issue. The entries in the frontend device
> > XXX area are writeable by the guest but maybe the solution is to
> > restrict that ?
> 
> No, I don't think so.  The frontend directory is precisely where the
> frontend writes things that it wants the backend to be able to read
> but the backend shouldn't rely on it for its own operation.

So you agree with the patch and not with my vacillating WRT whether it
is necessary?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>