WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] xen/gntdev: Fix sleep-inside-spinlock

To: Dario Faggioli <raistlin@xxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] xen/gntdev: Fix sleep-inside-spinlock
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Fri, 14 Oct 2011 09:54:59 -0400
Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 14 Oct 2011 06:55:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1318586226.5062.21.camel@Palantir>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1318353219.21925.80.camel@Palantir> <20111011173228.GB32406@xxxxxxxxxxxxxxxxx> <4E9495F6.4070301@xxxxxxxxxxxxx> <1318586226.5062.21.camel@Palantir>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Oct 14, 2011 at 11:57:05AM +0200, Dario Faggioli wrote:
> On Tue, 2011-10-11 at 15:16 -0400, Daniel De Graaf wrote:
> > gntdev_put_map tries to acquire a mutex when freeing pages back to the
> > xenballoon pool, so it cannot be called with a spinlock held. In
> > gntdev_release, the spinlock is not needed as we are freeing the
> > structure later; in the ioctl, only the list manipulation needs to be
> > under the lock.
> > 
> > Reported-By: Dario Faggioli <raistlin@xxxxxxxx>
> > Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> >
> Ok, I finally manage in testing this, and it actually cures the issue
> here!
> 
> You can add a tested-by tag if you like. Just, if you don't mind, use my
> corp. e-mail for (both?) the tag(s): <dario.faggioli@xxxxxxxxxx>

Sure. Thx for checking it.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel