WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Other things we need to do with backend/blkfront Was:Re: [Xen-devel] Re:

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Other things we need to do with backend/blkfront Was:Re: [Xen-devel] Re: [PATCH 2 of 3] interface: Flesh out the BLKIF_OP_DISCARD description
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Thu, 13 Oct 2011 11:32:34 -0400
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "JBeulich@xxxxxxxx" <JBeulich@xxxxxxxx>
Delivery-date: Thu, 13 Oct 2011 08:33:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1318492807.21903.789.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1318457565@xxxxxxxxxxxxxxxxxxxxxxx> <15c2d70dbac3e31c2d74.1318457567@xxxxxxxxxxxxxxxxxxxxxxx> <1318492807.21903.789.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
> Could we simplify and say that blkback won't expose discard support
> unless the underlying block device is correctly aligned for it? i.e.
> encourage people to align their underlying storage correctly? Presumably
> doing that has other benefits?

It got me thinking that we could do this - but I do not think that should
be spelled out in the interface. Rather it is up to the backend to either
expose it or not. The check for -1 in backend for that should do it. Keep
in mind that the discard operation is a hint, nothing else.

It also got me thinking about the aligment offset - which we do not
expose to the frontend. That is the one where the 63 sector DOS partition
ends up skewing up the whole disk layout. That is seperate from discard
operations.

It is more of a XenBus attribute. Then there is also the device serial
number which we don't expose either.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel