WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 0 of 4 v2] libxl: support json for pretty printin

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 0 of 4 v2] libxl: support json for pretty printing objects
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Thu, 13 Oct 2011 10:31:34 +0100
Delivery-date: Thu, 13 Oct 2011 02:32:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1317983270@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1317983270@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-10-07 at 11:27 +0100, Ian Campbell wrote:
> Now that Anthony's QMP series is in we can build upon the use of YAJL
> to add support for pretty printing libxl objects as JSON.
> 
> Also includes a user in xl (to print disks on dry run) and an
> associated fix to the check-xl-disk-parse test script.


In my V1 posting of this series I also included "libxl: probe disk
backend type in libxl_device_disk_add" but forgot it in the repost, so
here is patch 5/4:

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1318498260 -3600
# Node ID 29bd271877873f4a38217de89f8f4f74405496b5
# Parent  98cb420b606bf69e3e3177ebe8b16b529c5ed0ed
libxl: probe disk backend type in libxl_device_disk_add

Without this "xl block-attach" does not work. On create do_domain_create already
catches this.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 98cb420b606b -r 29bd27187787 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Thu Oct 13 10:31:00 2011 +0100
+++ b/tools/libxl/libxl.c       Thu Oct 13 10:31:00 2011 +0100
@@ -929,6 +929,9 @@ int libxl_device_disk_add(libxl_ctx *ctx
     rc = libxl__device_disk_set_backend(&gc, disk);
     if (rc) goto out;
 
+    rc = libxl__device_disk_set_backend(&gc, disk);
+    if (rc) goto out;
+
     front = flexarray_make(16, 1);
     if (!front) {
         rc = ERROR_NOMEM;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel