| 
         
xen-devel
[Xen-devel] Re: [PATCH][RFC] jump_labels/x86: Use either 5 byte or	2 byt
 
| 
To:  | 
Jason Baron <jbaron@xxxxxxxxxx> | 
 
| 
Subject:  | 
[Xen-devel] Re: [PATCH][RFC] jump_labels/x86: Use either 5 byte or	2 byte jumps | 
 
| 
From:  | 
Steven Rostedt <rostedt@xxxxxxxxxxx> | 
 
| 
Date:  | 
Fri, 07 Oct 2011 15:33:08 -0400 | 
 
| 
Cc:  | 
Jeremy Fitzhardinge <jeremy@xxxxxxxx>,	the arch/x86 maintainers <x86@xxxxxxxxxx>,	Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>,	David Daney <david.daney@xxxxxxxxxx>, peterz@xxxxxxxxxxxxx,	Jan Glauber <jang@xxxxxxxxxxxxxxxxxx>, Michael,	Richard Henderson <rth@xxxxxxxxxx>,	Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>,	Ellerman <michael@xxxxxxxxxxxxxx>,	Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>,	"H. Peter Anvin" <hpa@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx> | 
 
| 
Delivery-date:  | 
Fri, 07 Oct 2011 12:34:54 -0700 | 
 
| 
Envelope-to:  | 
www-data@xxxxxxxxxxxxxxxxxxx | 
 
| 
List-help:  | 
<mailto:xen-devel-request@lists.xensource.com?subject=help> | 
 
| 
List-id:  | 
Xen developer discussion <xen-devel.lists.xensource.com> | 
 
| 
List-post:  | 
<mailto:xen-devel@lists.xensource.com> | 
 
| 
List-subscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> | 
 
| 
List-unsubscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> | 
 
| 
References:  | 
<4E8CF385.2080804@xxxxxxxxx> <4E8DEB19.1050509@xxxxxxxx>	<20111006181055.GA2505@xxxxxxxxxx>	<1317925615.4729.14.camel@xxxxxxxxxxxxxxxxxxx>	<4E8DF870.6010000@xxxxxxxxxx>	<1317929321.4729.17.camel@xxxxxxxxxxxxxxxxxxx>	<4E8E20CD.5030207@xxxxxxxx>	<1317938775.4729.29.camel@xxxxxxxxxxxxxxxxxxx>	<4E8E275F.6010801@xxxxxxxx>	<1318007374.4729.58.camel@xxxxxxxxxxxxxxxxxxx>	<20111007185214.GD2978@xxxxxxxxxx> | 
 
| 
Sender:  | 
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx | 
 
 
 
On Fri, 2011-10-07 at 15:21 -0400, Steven Rostedt wrote:
> > > + /*
> > > +  * This is specific to x86. The jump_table is stored in three
> > > +  * long words. The first is the location of the jmp target we
> > > +  * must update.
> > > +  */
> > > + cnt = size / sizeof(uint_t);
> > > +
> > > + for (i = 0; i < cnt; i += 3)
> > > +         if (0)make_nop((void *)ehdr, *(uint_t *)(data + i * 
> > > sizeof(uint_t)));
I just compiled and booted the 
-               if (0)make_nop((void *)ehdr, *(uint_t *)(data + i * 
sizeof(uint_t)));
+               make_nop((void *)ehdr, *(uint_t *)(data + i * sizeof(uint_t)));
version, and it still works.
Phew!
-- Steve
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 
 |   
 
| <Prev in Thread] | 
Current Thread | 
[Next in Thread>
 |  
- [Xen-devel] Re: [PATCH RFC V2 3/5] jump_label: if a key has already been initialized, don't nop it out, (continued)
 
- [Xen-devel] Re: [PATCH][RFC] jump_labels/x86: Use either 5 byte or	2 byte jumps, Jason Baron
 - [Xen-devel] Re: [PATCH][RFC] jump_labels/x86: Use either 5 byte or	2 byte jumps, Steven Rostedt
 - [Xen-devel] Re: [PATCH][RFC] jump_labels/x86: Use either 5 byte or	2 byte jumps, H. Peter Anvin
 - [Xen-devel] Re: [PATCH][RFC] jump_labels/x86: Use either 5 byte or	2 byte jumps, Steven Rostedt
 - [Xen-devel] Re: [PATCH][RFC] jump_labels/x86: Use either 5 byte or	2 byte jumps, H. Peter Anvin
 
- [Xen-devel] Re: [PATCH][RFC] jump_labels/x86: Use either 5 byte or	2 byte jumps,
Steven Rostedt <=
 
- [Xen-devel] Re: [PATCH RFC V2 3/5] jump_label: if a key has already been initialized, don't nop it out, Jason Baron
 - [Xen-devel] Re: [PATCH RFC V2 3/5] jump_label: if a key has already been initialized, don't nop it out, Steven Rostedt
 
 
[Xen-devel] Re: [PATCH RFC V2 3/5] jump_label: if a key has already been initialized, don't nop it out, Jason Baron
[Xen-devel] [PATCH RFC V2 4/5] x86/jump_label: drop	arch_jump_label_text_poke_early(), Jeremy Fitzhardinge
 |  
  
 | 
    |