WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification

To: Keir Fraser <keir.xen@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Fri, 7 Oct 2011 09:04:13 +0100
Cc: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 07 Oct 2011 01:07:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CAB47030.22675%keir.xen@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <CAB47030.22675%keir.xen@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-10-07 at 09:00 +0100, Keir Fraser wrote:
> On 07/10/2011 08:51, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote:
> 
> > On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote:
> >> XEN_ROOT must be set to an absolute path to avoid out of the tree 
> >> references
> > 
> > How about:
> > 
> > # HG changeset patch
> > # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> > # Date 1317973741 -3600
> > # Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16
> > # Parent  f17f0df2a2ede01a8c35dc4768a532a4438b1c02
> > tools: error out on non-absolute $(XEN_ROOT)
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Why not put this in root Config.mk?

Didn't think of it...

> The restriction applies outside tools/ as well.

Seems to work.

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1317974632 -3600
# Node ID 02be23c18197d1bdea51031efb8c69ce32bcd7b3
# Parent  f17f0df2a2ede01a8c35dc4768a532a4438b1c02
tools: error out on non-absolute $(XEN_ROOT)

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r f17f0df2a2ed -r 02be23c18197 Config.mk
--- a/Config.mk Wed Oct 05 10:43:41 2011 +0100
+++ b/Config.mk Fri Oct 07 09:03:52 2011 +0100
@@ -1,5 +1,9 @@
 # -*- mode: Makefile; -*-
 
+ifeq ($(filter /%,$(XEN_ROOT)),)
+$(error XEN_ROOT must be absolute)
+endif
+
 -include $(XEN_ROOT)/.config
 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>