WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 1 of 2] build: link to specific library version (

To: Roger Pau Monne <roger.pau@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 1 of 2] build: link to specific library version (libxs, libxl, xenstore, xenstat)
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Thu, 6 Oct 2011 12:46:40 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 06 Oct 2011 04:48:10 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <fb73bd21cdf7aed429f7.1317900425@loki>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1317900424@loki> <fb73bd21cdf7aed429f7.1317900425@loki>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2011-10-06 at 12:27 +0100, Roger Pau Monne wrote:
> @@ -18,19 +33,19 @@ XEN_BLKTAP2        = $(XEN_ROOT)/tools/b
>  CFLAGS_xeninclude = -I$(XEN_INCLUDE)
> 
>  CFLAGS_libxenctrl = -I$(XEN_LIBXC) $(CFLAGS_xeninclude)
> -LDLIBS_libxenctrl = -L$(XEN_LIBXC) -lxenctrl
> +LDLIBS_libxenctrl = $(XEN_LIBXC)/libxenctrl.so.$(XCMAJOR).$(XCMINOR)
>  SHLIB_libxenctrl  = -Wl,-rpath-link=$(XEN_LIBXC)

I think this is the correct approach but you don't need
the .$(MAJOR).$(MINOR) suffix here since the .so at the specific path
will always be a symlink to the right thing (same for all the others).

Doing it that way will remove the need to move all the major/minor
definitions around and make this patch tiny.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel