WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 00 of 23] libxl: rationalise libxl_device_* APIs

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 00 of 23] libxl: rationalise libxl_device_* APIs
From: Roger Pau Monné <roger.pau@xxxxxxxxxxxxx>
Date: Wed, 5 Oct 2011 15:15:54 +0200
Cc: Mike McClurg <mike.mcclurg@xxxxxxxxxx>, Jim Fehlig <jfehlig@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jonathan Ludlam <Jonathan.Ludlam@xxxxxxxxxxxxx>, Dave Scott <Dave.Scott@xxxxxxxxxxxxx>
Delivery-date: Wed, 05 Oct 2011 06:16:33 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=PcVe4oFSXO2cqOb5fXNcMIvORFCoY3qh/xgqndQCvRc=; b=l9oQpDmDewxj1t08f1wNxrgoK6OkH297a8jn69jiwQIlVjh0yevpJyYYdt4QPjwj4u REJKlHTF1N46KtUoAIIf1eSOGExfWzR+E5uBRnDlaQD25KN4YcP8fMFfYMfM9E1ndQri rces16DT5KeU4nVIE+I09m7icmn9GMxAl61IM=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1317820080.21903.213.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1317389593@xxxxxxxxxxxxxxxxxxxxx> <CAPLaKK7qFpZcrjWdNESwotc70KVVvNpC1SOoSqc9esFKJoM3=Q@xxxxxxxxxxxxxx> <1317715976.21903.73.camel@xxxxxxxxxxxxxxxxxxxxxx> <1317717163.21903.80.camel@xxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK5w_ott56OYzwHg7b2SXbkoDyVsLCe+gauASUCaHeiv2w@xxxxxxxxxxxxxx> <1317807198.21903.184.camel@xxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK54T=8SQR-ZOn82HQaK9V7D46SvS+MyUYgb0DfydurS_A@xxxxxxxxxxxxxx> <1317820080.21903.213.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>> gcc -L/usr/xen42/lib   -o xl xl.o xl_cmdimpl.o xl_cmdtable.o
>> libxlutil.so -L/root/xen-04102011/tools/libxl/../../tools/libxl
>> -Wl,-rpath-link=/root/xen-04102011/tools/libxl/../../tools/libxc
>> -Wl,-rpath-link=/root/xen-04102011/tools/libxl/../../tools/xenstore
>> -lxenlight -L/root/xen-04102011/tools/libxl/../../tools/libxc
>> -lxenctrl
>> xl_cmdimpl.o: In function `parse_disk_config_multistring':
>> /root/xen-04102011/tools/libxl/xl_cmdimpl.c:497: undefined reference
>> to `libxl_device_disk_init'
>
> This function was added by "libxl: convert disk handling to device
> API" (patch #17/23). The others were generally added by the "convert XXX
> handling to ..." patches.
>
> I suspect that the -L/usr/xen42/lib in your link line has caused it to
> try and link against the installed libxenlight.so and not the just built
> one. My link line does not include this, it is just:
> gcc    -o xl xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so
> -L/local/scratch/ianc/devel/xen-unstable.hg/tools/libxl/../../tools/libxl 
> -Wl,-rpath-link=/local/scratch/ianc/devel/xen-unstable.hg/tools/libxl/../../tools/libxc
>  
> -Wl,-rpath-link=/local/scratch/ianc/devel/xen-unstable.hg/tools/libxl/../../tools/xenstore
>  
> -Wl,-rpath-link=/local/scratch/ianc/devel/xen-unstable.hg/tools/libxl/../../tools/blktap2/control
>  -lxenlight 
> -L/local/scratch/ianc/devel/xen-unstable.hg/tools/libxl/../../tools/libxc 
> -lxenctrl
>
> SO I guess you have LDFLAGS=-L/usr/xen42/lib -- what is that for? It
> should not be necessary when building Xen itself.

The -L/usr/xen42/lib is for yajl, the problem was that it was missing
libxenlight.so, so it could not link to the proper functions (or it
was trying to use the old library from /usr/xen42/lib instead of the
new one). I've modified a patch in your series to include
libxenligh.so when compiling xl.

Now I have a similar problem, and I think it's because Xen is trying
to use the old header files and libraries in /usr/xen42/ instead of
the new ones.

gcc -O2 -g -DHAVE_DB_185_H -I/usr/include -I/usr/pkg/include
-I/usr/xen42/include -O1 -fno-omit-frame-pointer -m64 -g
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wno-unused-value -Wdeclaration-after-statement -O1
-fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall
-Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement
-O1 -fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99
-Wall -Wstrict-prototypes -Wno-unused-value
-Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF
.subdirs-install.d -fno-optimize-sibling-calls -O1
-fno-omit-frame-pointer -m64 -g -fno-strict-aliasing -std=gnu99 -Wall
-Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement
-D__XEN_TOOLS__ -MMD -MF .subdir-install-python.d
-fno-optimize-sibling-calls -O1 -fno-omit-frame-pointer -m64 -g
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD
-MF .build.d -fno-optimize-sibling-calls -fPIC -I../../tools/include
-I../../tools/libxl -I../../tools/libxc -Ixen/lowlevel/xl
-I/usr/pkg/include/python2.6 -c xen/lowlevel/xl/xl.c -o
build/temp.netbsd-5.99.52-amd64-2.6-pydebug/xen/lowlevel/xl/xl.o
-fno-strict-aliasing -Werror
cc1: warnings being treated as errors
xen/lowlevel/xl/xl.c: In function 'pyxl_pci_del':
xen/lowlevel/xl/xl.c:525: warning: implicit declaration of function
'libxl_device_pci_force_remove'
xen/lowlevel/xl/xl.c:530: error: too few arguments to function
'libxl_device_pci_remove'
xen/lowlevel/xl/xl.c: In function 'pyxl_pci_list_assignable':
xen/lowlevel/xl/xl.c:568: warning: passing argument 2 of
'libxl_device_pci_list_assignable' from incompatible pointer type
xen/lowlevel/xl/xl.c:568: error: too few arguments to function
'libxl_device_pci_list_assignable'
xen/lowlevel/xl/xl.c: In function 'pyxl_pci_list':
xen/lowlevel/xl/xl.c:605: warning: implicit declaration of function
'libxl_device_pci_list'
xen/lowlevel/xl/xl.c:605: warning: assignment makes pointer from
integer without a cast
error: command 'gcc' failed with exit status 1

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel