WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] QEMU: remove blktap when building for NetBSD

To: Roger Pau Monné <roger.pau@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] QEMU: remove blktap when building for NetBSD
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Wed, 5 Oct 2011 11:31:46 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 05 Oct 2011 03:34:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CAPLaKK45u9Z6u7K5-70Do9rVG5-QpeszsF+3V0kvfFEe0ESMKw@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1317737599-21217-1-git-send-email-roger.pau@xxxxxxxxxxxxx> <1317749511.24742.2.camel@xxxxxxxxxxxxxxxxxxxx> <CAPLaKK7rMSy+xn4twbuEUiLsxgv-JRRBYAwFaDuwRgBvisjk8g@xxxxxxxxxxxxxx> <1317801530.21903.163.camel@xxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK4Pf34THUrGK-msxkgox6cO8EaSpwhvZS+Xw13tYEwzDw@xxxxxxxxxxxxxx> <1317807208.21903.185.camel@xxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK4k8Nng6zud-ibcBMuyKn-UPdEw11+LMqDMi62nJqn58g@xxxxxxxxxxxxxx> <1317810213.21903.201.camel@xxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK45u9Z6u7K5-70Do9rVG5-QpeszsF+3V0kvfFEe0ESMKw@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2011-10-05 at 11:29 +0100, Roger Pau Monné wrote:
> > Ah, that's OK then. I thought the original author was this "Charlie
> > Root" guy/pseudonym, but I suppose that's actually you and/or an
> > artefact of your local git repo/git send-email.
> 
> Sorry for the trouble,

No problem.

> that is a problem with git, that doesn't get
> the name and email attributes right when using "git format-patch", I
> think that it used the default name of the root account, which is
> "Charlie", hence the "Charlie Root" name, at the end I had to remove
> the "From" fields manually, because I wasn't able to generate a patch
> with the proper "From" field.

I think the problem was probably actually a "git commit" time when the
Author field in the commit seems to have been set to "Charlie Root".
"git format-patch" just picks up on that and because it is different to
the sender it includes a From line.

You probably need to add a ~/.gitconfig containing e.g.:
[user]
        name = Ian Campbell
        email = ian.campbell@xxxxxxxxxx
so that "git commit" will pickup the right details and/or avoid
committing stuff as root.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel