 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] [PATCH 3 of 4] xenpaging: remove confusing comment from p2m_
| To: | xen-devel@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | [Xen-devel] [PATCH 3 of 4] xenpaging: remove confusing comment from p2m_mem_paging_populate |
| From: | Olaf Hering <olaf@xxxxxxxxx> |
| Date: | Mon, 03 Oct 2011 16:43:56 +0200 |
| Delivery-date: | Mon, 03 Oct 2011 07:48:12 -0700 |
| Dkim-signature: | v=1; a=rsa-sha1; c=relaxed/relaxed; t=1317653052; l=1078; s=domk; d=aepfle.de; h=To:From:Date:References:In-Reply-To:Subject: Content-Transfer-Encoding:MIME-Version:Content-Type:X-RZG-CLASS-ID: X-RZG-AUTH; bh=2epANTdflEUvjM++XVDkeKtjjQo=; b=EeCuFOy3TQ+C0wQCNoDtqyZqxKy1R0cYPdznWDluXmyVL36rc2LQTlZzgVOqStvPnUi xbSdnsuerTnK+wWqQ39MNr/3yzb79HxfllQxT8eJEBm6vLQRUDdXRcK7fXPiMExmpTjmu HV4TARkYUkFGhVHw0fBCE/OqZNpEWyTnmg4= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <patchbomb.1317653033@xxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <patchbomb.1317653033@xxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mercurial-patchbomb/1.7.5 |
# HG changeset patch
# User Olaf Hering <olaf@xxxxxxxxx>
# Date 1317652811 -7200
# Node ID 13872c432c3807e0f977d9c1311801179807ece2
# Parent 6bf1aa780b9ff40c50cfd00cfa8796ccc76286ee
xenpaging: remove confusing comment from p2m_mem_paging_populate
Currently there is no way to avoid the double check of the p2mt
because p2m_mem_paging_populate() is called from many places without
the p2m_lock held. Upcoming changes will move the function into
gfn_to_mfn(), so its interface could be changed and the extra
p2m_lock/get_entry can be removed.
Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
diff -r 6bf1aa780b9f -r 13872c432c38 xen/arch/x86/mm/p2m.c
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -792,8 +792,6 @@ void p2m_mem_paging_populate(struct doma
req.type = MEM_EVENT_TYPE_PAGING;
/* Fix p2m mapping */
- /* XXX: It seems inefficient to have this here, as it's only needed
- * in one case (ept guest accessing paging out page) */
p2m_lock(p2m);
p2m->get_entry(p2m, gfn, &p2mt, &a, p2m_query, NULL);
if ( p2mt == p2m_ram_paged )
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH 1 of 4] xenpaging: use p2m->get_entry() in p2m_mem_paging functions, Olaf Hering |
|---|---|
| Next by Date: | [Xen-devel] [PATCH 4 of 4] xenpaging: handle paged pages in p2m_pod_decrease_reservation, Olaf Hering |
| Previous by Thread: | [Xen-devel] [PATCH 1 of 4] xenpaging: use p2m->get_entry() in p2m_mem_paging functions, Olaf Hering |
| Next by Thread: | [Xen-devel] [PATCH 4 of 4] xenpaging: handle paged pages in p2m_pod_decrease_reservation, Olaf Hering |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
